habanalabs: free host huge va_range if not used

If huge range is not valid, driver uses the host range also for
huge page allocations, but driver never frees its allocation.
This introduces a memory leak every time a user closes its context.

Signed-off-by: Ofir Bitton <obitton@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>

diff --git a/drivers/misc/habanalabs/common/memory.c b/drivers/misc/habanalabs/common/memory.c
index 744275dd64109e6d4ae70c9f5500a64450829182..cbe9da4e0211b5118b112b2bdf92f91cfef46360 100644 (file)
--- a/drivers/misc/habanalabs/common/memory.c
+++ b/drivers/misc/habanalabs/common/memory.c
@@ -1761,6 +1761,7 @@ static int vm_ctx_init_with_ranges(struct hl_ctx *ctx,
                        goto clear_host_va_range;
                }
        } else {
+               kfree(ctx->va_range[HL_VA_RANGE_TYPE_HOST_HUGE]);
                ctx->va_range[HL_VA_RANGE_TYPE_HOST_HUGE] =
                                ctx->va_range[HL_VA_RANGE_TYPE_HOST];
        }
@@ -1906,9 +1907,10 @@ void hl_vm_ctx_fini(struct hl_ctx *ctx)
        spin_unlock(&vm->idr_lock);
 
        va_range_fini(hdev, ctx->va_range[HL_VA_RANGE_TYPE_DRAM]);
+       va_range_fini(hdev, ctx->va_range[HL_VA_RANGE_TYPE_HOST]);
+
        if (hdev->pmmu_huge_range)
                va_range_fini(hdev, ctx->va_range[HL_VA_RANGE_TYPE_HOST_HUGE]);
-       va_range_fini(hdev, ctx->va_range[HL_VA_RANGE_TYPE_HOST]);
 
        mutex_destroy(&ctx->mem_hash_lock);
        hl_mmu_ctx_fini(ctx);