phy: Use of_property_present() for testing DT property presence
authorRob Herring <robh@kernel.org>
Fri, 10 Mar 2023 14:47:20 +0000 (08:47 -0600)
committerVinod Koul <vkoul@kernel.org>
Mon, 20 Mar 2023 12:44:58 +0000 (18:14 +0530)
It is preferred to use typed property access functions (i.e.
of_property_read_<type> functions) rather than low-level
of_get_property/of_find_property functions for reading properties. As
part of this, convert of_get_property/of_find_property calls to the
recently added of_property_present() helper when we just want to test
for presence of a property and nothing more.

Signed-off-by: Rob Herring <robh@kernel.org>
Reviewed-by: Jernej Skrabec <jernej.skrabec@gmail.com>
Link: https://lore.kernel.org/r/20230310144720.1544600-1-robh@kernel.org
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/allwinner/phy-sun4i-usb.c
drivers/phy/broadcom/phy-bcm-ns-usb2.c

index 6a74e5ce180aabda4f040b3240522263a141488b..56d53f78d002242ed00621dc54293baea45b01d5 100644 (file)
@@ -756,7 +756,7 @@ static int sun4i_usb_phy_probe(struct platform_device *pdev)
                return PTR_ERR(data->vbus_det_gpio);
        }
 
-       if (of_find_property(np, "usb0_vbus_power-supply", NULL)) {
+       if (of_property_present(np, "usb0_vbus_power-supply")) {
                data->vbus_power_supply = devm_power_supply_get_by_phandle(dev,
                                                     "usb0_vbus_power-supply");
                if (IS_ERR(data->vbus_power_supply)) {
index 6a36e187d100d9b1c52730ed54ededa9dccd6cbd..269564bdf68718d5aeaffbcbe6b734366faf37f8 100644 (file)
@@ -107,7 +107,7 @@ static int bcm_ns_usb2_probe(struct platform_device *pdev)
                return -ENOMEM;
        usb2->dev = dev;
 
-       if (of_find_property(dev->of_node, "brcm,syscon-clkset", NULL)) {
+       if (of_property_present(dev->of_node, "brcm,syscon-clkset")) {
                usb2->base = devm_platform_ioremap_resource(pdev, 0);
                if (IS_ERR(usb2->base)) {
                        dev_err(dev, "Failed to map control reg\n");