crypto: talitos - don't leak pointers to authenc keys

In talitos's aead_setkey we save pointers to the authenc keys in a
local variable of type struct crypto_authenc_keys and we don't
zeroize it after use. Fix this and don't leak pointers to the
authenc keys.

Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Reviewed-by: Christophe Leroy <christophe.leroy@c-s.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/talitos.c b/drivers/crypto/talitos.c
index 3cfd53a00dc18df3bcbcd0ae4e8fac8036da8490..7cebf0a6ffbca83201f88a20a00c40924ed3f52f 100644 (file)
--- a/drivers/crypto/talitos.c
+++ b/drivers/crypto/talitos.c
@@ -904,10 +904,12 @@ static int aead_setkey(struct crypto_aead *authenc,
        ctx->dma_key = dma_map_single(dev, ctx->key, ctx->keylen,
                                      DMA_TO_DEVICE);
 
+       memzero_explicit(&keys, sizeof(keys));
        return 0;
 
 badkey:
        crypto_aead_set_flags(authenc, CRYPTO_TFM_RES_BAD_KEY_LEN);
+       memzero_explicit(&keys, sizeof(keys));
        return -EINVAL;
 }