clocksource: Convert s[n]printf() to sysfs_emit()
authorLi Zhijian <lizhijian@fujitsu.com>
Thu, 14 Mar 2024 10:04:01 +0000 (18:04 +0800)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 9 Apr 2024 10:32:37 +0000 (12:32 +0200)
Per filesystems/sysfs.rst, show() should only use sysfs_emit() or
sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/r/20240314100402.1326582-1-lizhijian@fujitsu.com
kernel/time/clocksource.c

index 4d50d53ac719f2f5a2aa7925f8f0b27bc6262eed..d25ba49e313cca182029e272b7bac004773f92a8 100644 (file)
@@ -1334,7 +1334,7 @@ static ssize_t current_clocksource_show(struct device *dev,
        ssize_t count = 0;
 
        mutex_lock(&clocksource_mutex);
-       count = snprintf(buf, PAGE_SIZE, "%s\n", curr_clocksource->name);
+       count = sysfs_emit(buf, "%s\n", curr_clocksource->name);
        mutex_unlock(&clocksource_mutex);
 
        return count;