PCI: iproc: Use of_property_read_bool() for boolean properties
authorRob Herring <robh@kernel.org>
Fri, 9 Jun 2023 19:33:25 +0000 (13:33 -0600)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Thu, 13 Jul 2023 18:09:24 +0000 (18:09 +0000)
Replace low-level property access functions like of_get_property() and
of_find_property() with their typed equivalents (i.e., of_property_read_<type>
functions), as it's preferred to use typed property access functions for
reading properties.

[kwilczynski: commit log]
Link: https://lore.kernel.org/linux-pci/20230609193326.1963542-1-robh@kernel.org
Signed-off-by: Rob Herring <robh@kernel.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Acked-by: Ray Jui <ray.jui@broadcom.com>
drivers/pci/controller/pcie-iproc-msi.c

index fee036b07cd4f6ac53c501ce7efdcfa8604e3893..649fcb449f34401381739a42e4b56bef723e4acc 100644 (file)
@@ -525,7 +525,7 @@ int iproc_msi_init(struct iproc_pcie *pcie, struct device_node *node)
        if (!of_device_is_compatible(node, "brcm,iproc-msi"))
                return -ENODEV;
 
-       if (!of_find_property(node, "msi-controller", NULL))
+       if (!of_property_read_bool(node, "msi-controller"))
                return -ENODEV;
 
        if (pcie->msi)
@@ -585,8 +585,7 @@ int iproc_msi_init(struct iproc_pcie *pcie, struct device_node *node)
                return -EINVAL;
        }
 
-       if (of_find_property(node, "brcm,pcie-msi-inten", NULL))
-               msi->has_inten_reg = true;
+       msi->has_inten_reg = of_property_read_bool(node, "brcm,pcie-msi-inten");
 
        msi->nr_msi_vecs = msi->nr_irqs * EQ_LEN;
        msi->bitmap = devm_bitmap_zalloc(pcie->dev, msi->nr_msi_vecs,