devtmpfs: drop redundant fs parameters from internal fs
authorAnthony Iliopoulos <ailiop@suse.com>
Wed, 19 Jan 2022 22:02:48 +0000 (23:02 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Feb 2022 14:38:01 +0000 (15:38 +0100)
The internal_fs_type is mounted via vfs_kernel_mount() and is never
registered as a filesystem, thus specifying the parameters is redundant
as those params will not be validated by fs_validate_description().

Both {shmem,ramfs}_fs_parameters are anyway validated when those
respective filesystems are first registered, so there is no reason to
pass them to devtmpfs too, drop them.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Christian Brauner <christian.brauner@ubuntu.com>
Signed-off-by: Anthony Iliopoulos <ailiop@suse.com>
Link: https://lore.kernel.org/r/20220119220248.32225-1-ailiop@suse.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/devtmpfs.c

index f41063ac1aee478e668913187d8571b0b4317f21..ad5f304e2b3069b38b54e0dcd6b872f2ddbe2354 100644 (file)
@@ -81,10 +81,8 @@ static struct file_system_type internal_fs_type = {
        .name = "devtmpfs",
 #ifdef CONFIG_TMPFS
        .init_fs_context = shmem_init_fs_context,
-       .parameters     = shmem_fs_parameters,
 #else
        .init_fs_context = ramfs_init_fs_context,
-       .parameters     = ramfs_fs_parameters,
 #endif
        .kill_sb = kill_litter_super,
 };