qca_spi: Log expected signature in error case
authorStefan Wahren <wahrenst@gmx.net>
Sun, 28 Jan 2024 20:10:54 +0000 (21:10 +0100)
committerDavid S. Miller <davem@davemloft.net>
Wed, 31 Jan 2024 13:38:50 +0000 (13:38 +0000)
Most of the users doesn't know the expected signature of the QCA700x.
So provide it within the error message. Btw use lowercase for hex as
in the rest of the driver.

Signed-off-by: Stefan Wahren <wahrenst@gmx.net>
Reviewed-by: Jacob Keller <jacob.e.keller@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qualcomm/qca_spi.c

index b35fabcd488be9fdd68e78db5460dafd873b60fc..d2d68c20b32c19ce0697d145e308e53c0252cf27 100644 (file)
@@ -1006,8 +1006,8 @@ qca_spi_probe(struct spi_device *spi)
                qcaspi_read_register(qca, SPI_REG_SIGNATURE, &signature);
 
                if (signature != QCASPI_GOOD_SIGNATURE) {
-                       dev_err(&spi->dev, "Invalid signature (0x%04X)\n",
-                               signature);
+                       dev_err(&spi->dev, "Invalid signature (expected 0x%04x, read 0x%04x)\n",
+                               QCASPI_GOOD_SIGNATURE, signature);
                        free_netdev(qcaspi_devs);
                        return -EFAULT;
                }