drm/panfrost: Merge some feature lists
authorAlyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Sun, 9 Jan 2022 17:09:19 +0000 (12:09 -0500)
committerSteven Price <steven.price@arm.com>
Thu, 13 Jan 2022 09:48:39 +0000 (09:48 +0000)
Now that we only list features of interest to kernel space, lots of GPUs
have the same feature bits. To cut down on the repetition in the file,
merge feature lists that are identical between similar GPUs.

Note that this leaves some unmerged identical Bifrost feature lists, as
there are more features affecting Bifrost kernel space that we do not
yet handle.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
[Steve: fix typo in commit message]
Reviewed-by: Steven Price <steven.price@arm.com>
Signed-off-by: Steven Price <steven.price@arm.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220109170920.2921-3-alyssa.rosenzweig@collabora.com
drivers/gpu/drm/panfrost/panfrost_features.h

index f557fad5d5ff319c320423900fde4183421c19c1..34f2bae1ec8cc5f52f2277666862eb2c6334af98 100644 (file)
@@ -27,14 +27,9 @@ enum panfrost_hw_feature {
        BIT_ULL(HW_FEATURE_THREAD_GROUP_SPLIT) | \
        BIT_ULL(HW_FEATURE_V4))
 
-#define hw_features_t620 (\
-       BIT_ULL(HW_FEATURE_THREAD_GROUP_SPLIT) | \
-       BIT_ULL(HW_FEATURE_V4))
-
-#define hw_features_t720 (\
-       BIT_ULL(HW_FEATURE_THREAD_GROUP_SPLIT) | \
-       BIT_ULL(HW_FEATURE_V4))
+#define hw_features_t620 hw_features_t600
 
+#define hw_features_t720 hw_features_t600
 
 #define hw_features_t760 (\
        BIT_ULL(HW_FEATURE_JOBCHAIN_DISAMBIGUATION) | \
@@ -42,26 +37,13 @@ enum panfrost_hw_feature {
        BIT_ULL(HW_FEATURE_XAFFINITY) | \
        BIT_ULL(HW_FEATURE_THREAD_GROUP_SPLIT))
 
-// T860
-#define hw_features_t860 (\
-       BIT_ULL(HW_FEATURE_JOBCHAIN_DISAMBIGUATION) | \
-       BIT_ULL(HW_FEATURE_PWRON_DURING_PWROFF_TRANS) | \
-       BIT_ULL(HW_FEATURE_XAFFINITY) | \
-       BIT_ULL(HW_FEATURE_THREAD_GROUP_SPLIT))
+#define hw_features_t860 hw_features_t760
 
-#define hw_features_t880 hw_features_t860
+#define hw_features_t880 hw_features_t760
 
-#define hw_features_t830 (\
-       BIT_ULL(HW_FEATURE_JOBCHAIN_DISAMBIGUATION) | \
-       BIT_ULL(HW_FEATURE_PWRON_DURING_PWROFF_TRANS) | \
-       BIT_ULL(HW_FEATURE_XAFFINITY) | \
-       BIT_ULL(HW_FEATURE_THREAD_GROUP_SPLIT))
+#define hw_features_t830 hw_features_t760
 
-#define hw_features_t820 (\
-       BIT_ULL(HW_FEATURE_JOBCHAIN_DISAMBIGUATION) | \
-       BIT_ULL(HW_FEATURE_PWRON_DURING_PWROFF_TRANS) | \
-       BIT_ULL(HW_FEATURE_XAFFINITY) | \
-       BIT_ULL(HW_FEATURE_THREAD_GROUP_SPLIT))
+#define hw_features_t820 hw_features_t760
 
 #define hw_features_g71 (\
        BIT_ULL(HW_FEATURE_JOBCHAIN_DISAMBIGUATION) | \
@@ -82,15 +64,7 @@ enum panfrost_hw_feature {
        BIT_ULL(HW_FEATURE_PROTECTED_DEBUG_MODE) | \
        BIT_ULL(HW_FEATURE_COHERENCY_REG))
 
-#define hw_features_g51 (\
-       BIT_ULL(HW_FEATURE_JOBCHAIN_DISAMBIGUATION) | \
-       BIT_ULL(HW_FEATURE_PWRON_DURING_PWROFF_TRANS) | \
-       BIT_ULL(HW_FEATURE_XAFFINITY) | \
-       BIT_ULL(HW_FEATURE_THREAD_GROUP_SPLIT) | \
-       BIT_ULL(HW_FEATURE_FLUSH_REDUCTION) | \
-       BIT_ULL(HW_FEATURE_PROTECTED_MODE) | \
-       BIT_ULL(HW_FEATURE_PROTECTED_DEBUG_MODE) | \
-       BIT_ULL(HW_FEATURE_COHERENCY_REG))
+#define hw_features_g51 hw_features_g72
 
 #define hw_features_g52 (\
        BIT_ULL(HW_FEATURE_JOBCHAIN_DISAMBIGUATION) | \