drm/msm/dpu: Annotate struct dpu_hw_intr with __counted_by
authorKees Cook <keescook@chromium.org>
Fri, 22 Sep 2023 17:32:09 +0000 (10:32 -0700)
committerChristian König <christian.koenig@amd.com>
Thu, 5 Oct 2023 09:30:50 +0000 (11:30 +0200)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).

As found with Coccinelle[1], add __counted_by for struct dpu_hw_intr.

[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci

Cc: Rob Clark <robdclark@gmail.com>
Cc: Abhinav Kumar <quic_abhinavk@quicinc.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Sean Paul <sean@poorly.run>
Cc: Marijn Suijten <marijn.suijten@somainline.org>
Cc: David Airlie <airlied@gmail.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: linux-arm-msm@vger.kernel.org
Cc: dri-devel@lists.freedesktop.org
Cc: freedreno@lists.freedesktop.org
Signed-off-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Christian König <christian.koenig@amd.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20230922173216.3823169-4-keescook@chromium.org
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_interrupts.h

index 1f2dabc54c2299a7b982ff6b14ccffb55315e008..d6a17f052b3a62de583565a6253faa4af398fad0 100644 (file)
@@ -65,7 +65,7 @@ struct dpu_hw_intr {
                void (*cb)(void *arg, int irq_idx);
                void *arg;
                atomic_t count;
-       } irq_tbl[];
+       } irq_tbl[] __counted_by(total_irqs);
 };
 
 /**