selftests/cgroup: fix uninitialized variables in test_zswap.c
authorJohn Hubbard <jhubbard@nvidia.com>
Fri, 3 May 2024 03:51:05 +0000 (20:51 -0700)
committerTejun Heo <tj@kernel.org>
Fri, 3 May 2024 19:06:10 +0000 (09:06 -1000)
First of all, in order to build with clang at all, one must first apply
Valentin Obst's build fix for LLVM [1]. Once that is done, then when
building with clang, via:

    make LLVM=1 -C tools/testing/selftests

...clang finds and warning about some uninitialized variables. Fix these
by initializing them.

[1] https://lore.kernel.org/all/20240329-selftests-libmk-llvm-rfc-v1-1-2f9ed7d1c49f@valentinobst.de/

Signed-off-by: John Hubbard <jhubbard@nvidia.com>
Reviewed-by: Roman Gushchin <roman.gushchin@linux.dev>
Signed-off-by: Tejun Heo <tj@kernel.org>
tools/testing/selftests/cgroup/test_zswap.c

index ef7f39545317387b9b7c824531aa143ec86d9c24..fa571bfd24328475d90e0aee265701223a3d34eb 100644 (file)
@@ -257,7 +257,7 @@ static int test_no_invasive_cgroup_shrink(const char *root)
 {
        int ret = KSFT_FAIL;
        size_t control_allocation_size = MB(10);
-       char *control_allocation, *wb_group = NULL, *control_group = NULL;
+       char *control_allocation = NULL, *wb_group = NULL, *control_group = NULL;
 
        wb_group = setup_test_group_1M(root, "per_memcg_wb_test1");
        if (!wb_group)
@@ -342,7 +342,7 @@ static int test_no_kmem_bypass(const char *root)
        struct sysinfo sys_info;
        int ret = KSFT_FAIL;
        int child_status;
-       char *test_group;
+       char *test_group = NULL;
        pid_t child_pid;
 
        /* Read sys info and compute test values accordingly */