projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
bfa96be
)
iio: amplifiers: hmc425a: Simplify with dev_err_probe()
author
Krzysztof Kozlowski
<krzk@kernel.org>
Sat, 29 Aug 2020 06:47:18 +0000
(08:47 +0200)
committer
Jonathan Cameron
<Jonathan.Cameron@huawei.com>
Thu, 3 Sep 2020 18:40:50 +0000
(19:40 +0100)
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link:
https://lore.kernel.org/r/20200829064726.26268-10-krzk@kernel.org
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/amplifiers/hmc425a.c
patch
|
blob
|
history
diff --git
a/drivers/iio/amplifiers/hmc425a.c
b/drivers/iio/amplifiers/hmc425a.c
index 582708924e4fc67465bb9917b06774f33dde10a3..9efa692151f0f3b3e9bb3aad3096aac369feb009 100644
(file)
--- a/
drivers/iio/amplifiers/hmc425a.c
+++ b/
drivers/iio/amplifiers/hmc425a.c
@@
-201,12
+201,9
@@
static int hmc425a_probe(struct platform_device *pdev)
st->gain = st->chip_info->default_gain;
st->gpios = devm_gpiod_get_array(&pdev->dev, "ctrl", GPIOD_OUT_LOW);
- if (IS_ERR(st->gpios)) {
- ret = PTR_ERR(st->gpios);
- if (ret != -EPROBE_DEFER)
- dev_err(&pdev->dev, "failed to get gpios\n");
- return ret;
- }
+ if (IS_ERR(st->gpios))
+ return dev_err_probe(&pdev->dev, PTR_ERR(st->gpios),
+ "failed to get gpios\n");
if (st->gpios->ndescs != st->chip_info->num_gpios) {
dev_err(&pdev->dev, "%d GPIOs needed to operate\n",