Input: synaptics-rmi4 - use sysfs_emit() to instead of scnprintf()
authorye xingchen <ye.xingchen@zte.com.cn>
Wed, 13 Dec 2023 06:31:44 +0000 (22:31 -0800)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Thu, 14 Dec 2023 05:26:12 +0000 (21:26 -0800)
Replace calls to scnprintf() in the methods showing device attributes
with sysfs_emit() to simplify the code.

Signed-off-by: ye xingchen <ye.xingchen@zte.com.cn>
Link: https://lore.kernel.org/r/202212011551429834598@zte.com.cn
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/rmi4/rmi_f01.c

index d7603c50f864b329e1ef4dc9c75df885113e8cbb..cc1d4b424640ea3902cf726329b69c01aa23c4ba 100644 (file)
@@ -267,8 +267,7 @@ static ssize_t rmi_driver_manufacturer_id_show(struct device *dev,
        struct rmi_driver_data *data = dev_get_drvdata(dev);
        struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev);
 
-       return scnprintf(buf, PAGE_SIZE, "%d\n",
-                        f01->properties.manufacturer_id);
+       return sysfs_emit(buf, "%d\n", f01->properties.manufacturer_id);
 }
 
 static DEVICE_ATTR(manufacturer_id, 0444,
@@ -280,7 +279,7 @@ static ssize_t rmi_driver_dom_show(struct device *dev,
        struct rmi_driver_data *data = dev_get_drvdata(dev);
        struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev);
 
-       return scnprintf(buf, PAGE_SIZE, "%s\n", f01->properties.dom);
+       return sysfs_emit(buf, "%s\n", f01->properties.dom);
 }
 
 static DEVICE_ATTR(date_of_manufacture, 0444, rmi_driver_dom_show, NULL);
@@ -292,7 +291,7 @@ static ssize_t rmi_driver_product_id_show(struct device *dev,
        struct rmi_driver_data *data = dev_get_drvdata(dev);
        struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev);
 
-       return scnprintf(buf, PAGE_SIZE, "%s\n", f01->properties.product_id);
+       return sysfs_emit(buf, "%s\n", f01->properties.product_id);
 }
 
 static DEVICE_ATTR(product_id, 0444, rmi_driver_product_id_show, NULL);
@@ -304,7 +303,7 @@ static ssize_t rmi_driver_firmware_id_show(struct device *dev,
        struct rmi_driver_data *data = dev_get_drvdata(dev);
        struct f01_data *f01 = dev_get_drvdata(&data->f01_container->dev);
 
-       return scnprintf(buf, PAGE_SIZE, "%d\n", f01->properties.firmware_id);
+       return sysfs_emit(buf, "%d\n", f01->properties.firmware_id);
 }
 
 static DEVICE_ATTR(firmware_id, 0444, rmi_driver_firmware_id_show, NULL);
@@ -318,8 +317,8 @@ static ssize_t rmi_driver_package_id_show(struct device *dev,
 
        u32 package_id = f01->properties.package_id;
 
-       return scnprintf(buf, PAGE_SIZE, "%04x.%04x\n",
-                        package_id & 0xffff, (package_id >> 16) & 0xffff);
+       return sysfs_emit(buf, "%04x.%04x\n",
+                         package_id & 0xffff, (package_id >> 16) & 0xffff);
 }
 
 static DEVICE_ATTR(package_id, 0444, rmi_driver_package_id_show, NULL);