projects
/
linux.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
b90cb10
)
irqchip/stm32-exti: Remove check on always false condition
author
Antonio Borneo
<antonio.borneo@foss.st.com>
Wed, 17 Aug 2022 12:57:58 +0000
(14:57 +0200)
committer
Marc Zyngier
<maz@kernel.org>
Mon, 12 Sep 2022 15:31:25 +0000
(16:31 +0100)
The field drv_data is assigned during driver's probe, where it's
already checked to be not NULL.
Remove the always false check '!host_data->drv_data'.
This fixes a warning "variable dereferenced before check" detected
by '0-DAY CI Kernel Test Service'.
Fixes: c297493336b7 ("irqchip/stm32-exti: Simplify irq description table")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Link:
https://lore.kernel.org/lkml/202208131739.gJvcs9ls-lkp@intel.com/
Signed-off-by: Antonio Borneo <antonio.borneo@foss.st.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link:
https://lore.kernel.org/r/20220817125758.5975-1-antonio.borneo@foss.st.com
drivers/irqchip/irq-stm32-exti.c
patch
|
blob
|
history
diff --git
a/drivers/irqchip/irq-stm32-exti.c
b/drivers/irqchip/irq-stm32-exti.c
index a73763d475f04e277f4794fe7ccc048d8e6313bc..6a3f7498ea8eadacc08807b09d0b1bdbc97cc1d0 100644
(file)
--- a/
drivers/irqchip/irq-stm32-exti.c
+++ b/
drivers/irqchip/irq-stm32-exti.c
@@
-716,7
+716,7
@@
static int stm32_exti_h_domain_alloc(struct irq_domain *dm,
irq_domain_set_hwirq_and_chip(dm, virq, hwirq, chip, chip_data);
- if (!host_data->drv_data
|| !host_data->drv_data
->desc_irqs)
+ if (!host_data->drv_data->desc_irqs)
return -EINVAL;
desc_irq = host_data->drv_data->desc_irqs[hwirq];