scsi: ibmvscsit: Remove default fabric ops callouts
authorDmitry Bogdanov <d.bogdanov@yadro.com>
Mon, 13 Mar 2023 18:11:01 +0000 (21:11 +0300)
committerMartin K. Petersen <martin.petersen@oracle.com>
Fri, 17 Mar 2023 03:36:36 +0000 (23:36 -0400)
Remove callouts that are identical to the default implementations in TCM
Core.

Signed-off-by: Dmitry Bogdanov <d.bogdanov@yadro.com>
Link: https://lore.kernel.org/r/20230313181110.20566-4-d.bogdanov@yadro.com
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c

index e8770310a64b39e3d0d8b867154ddda2fa9bce67..385f812b8793c26ef3321df602b28f6123f401e9 100644 (file)
@@ -3698,16 +3698,6 @@ static int ibmvscsis_check_true(struct se_portal_group *se_tpg)
        return 1;
 }
 
-static int ibmvscsis_check_false(struct se_portal_group *se_tpg)
-{
-       return 0;
-}
-
-static u32 ibmvscsis_tpg_get_inst_index(struct se_portal_group *se_tpg)
-{
-       return 1;
-}
-
 static int ibmvscsis_check_stop_free(struct se_cmd *se_cmd)
 {
        return target_put_sess_cmd(se_cmd);
@@ -3726,11 +3716,6 @@ static void ibmvscsis_release_cmd(struct se_cmd *se_cmd)
        spin_unlock_bh(&vscsi->intr_lock);
 }
 
-static u32 ibmvscsis_sess_get_index(struct se_session *se_sess)
-{
-       return 0;
-}
-
 static int ibmvscsis_write_pending(struct se_cmd *se_cmd)
 {
        struct ibmvscsis_cmd *cmd = container_of(se_cmd, struct ibmvscsis_cmd,
@@ -3765,15 +3750,6 @@ static int ibmvscsis_write_pending(struct se_cmd *se_cmd)
        return 0;
 }
 
-static void ibmvscsis_set_default_node_attrs(struct se_node_acl *nacl)
-{
-}
-
-static int ibmvscsis_get_cmd_state(struct se_cmd *se_cmd)
-{
-       return 0;
-}
-
 static int ibmvscsis_queue_data_in(struct se_cmd *se_cmd)
 {
        struct ibmvscsis_cmd *cmd = container_of(se_cmd, struct ibmvscsis_cmd,
@@ -3982,15 +3958,9 @@ static const struct target_core_fabric_ops ibmvscsis_ops = {
        .tpg_get_default_depth          = ibmvscsis_get_default_depth,
        .tpg_check_demo_mode            = ibmvscsis_check_true,
        .tpg_check_demo_mode_cache      = ibmvscsis_check_true,
-       .tpg_check_demo_mode_write_protect = ibmvscsis_check_false,
-       .tpg_check_prod_mode_write_protect = ibmvscsis_check_false,
-       .tpg_get_inst_index             = ibmvscsis_tpg_get_inst_index,
        .check_stop_free                = ibmvscsis_check_stop_free,
        .release_cmd                    = ibmvscsis_release_cmd,
-       .sess_get_index                 = ibmvscsis_sess_get_index,
        .write_pending                  = ibmvscsis_write_pending,
-       .set_default_node_attributes    = ibmvscsis_set_default_node_attrs,
-       .get_cmd_state                  = ibmvscsis_get_cmd_state,
        .queue_data_in                  = ibmvscsis_queue_data_in,
        .queue_status                   = ibmvscsis_queue_status,
        .queue_tm_rsp                   = ibmvscsis_queue_tm_rsp,