pinctrl: intel: Drop the only label in the code for consistency
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Fri, 12 Jun 2020 14:49:58 +0000 (17:49 +0300)
committerAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 22 Jun 2020 07:58:51 +0000 (10:58 +0300)
Drop the only label in the code, i.e. in intel_config_set_debounce(),
for consistency with the rest. In entire driver we use multipoint
return.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>
drivers/pinctrl/intel/pinctrl-intel.c

index 76b1b899a389b10d773324a0236f137b00d5c552..2bcda48ea29a30a4a3268f5a67862080b330e0ce 100644 (file)
@@ -695,7 +695,6 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl,
        void __iomem *padcfg0, *padcfg2;
        unsigned long flags;
        u32 value0, value2;
-       int ret = 0;
 
        padcfg2 = intel_get_padcfg(pctrl, pin, PADCFG2);
        if (!padcfg2)
@@ -717,8 +716,8 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl,
 
                v = order_base_2(debounce * NSEC_PER_USEC / DEBOUNCE_PERIOD_NSEC);
                if (v < 3 || v > 15) {
-                       ret = -EINVAL;
-                       goto exit_unlock;
+                       raw_spin_unlock_irqrestore(&pctrl->lock, flags);
+                       return -EINVAL;
                }
 
                /* Enable glitch filter and debouncer */
@@ -730,10 +729,9 @@ static int intel_config_set_debounce(struct intel_pinctrl *pctrl,
        writel(value0, padcfg0);
        writel(value2, padcfg2);
 
-exit_unlock:
        raw_spin_unlock_irqrestore(&pctrl->lock, flags);
 
-       return ret;
+       return 0;
 }
 
 static int intel_config_set(struct pinctrl_dev *pctldev, unsigned int pin,