fbdev/acornfb: Use fbdev I/O helpers
authorThomas Zimmermann <tzimmermann@suse.de>
Thu, 3 Aug 2023 18:35:27 +0000 (20:35 +0200)
committerThomas Zimmermann <tzimmermann@suse.de>
Fri, 4 Aug 2023 13:54:34 +0000 (15:54 +0200)
Set struct fb_ops and with FB_DEFAULT_IOMEM_OPS, fbdev's initializer
for I/O memory. Sets the callbacks to the cfb_ and fb_io_ functions.
Select the correct modules with Kconfig's FB_IOMEM_HELPERS token.

The macro and token set the currently selected values, so there is
no functional change.

v3:
* use _IOMEM_ in commit message
v2:
* updated to use _IOMEM_ tokens

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Acked-by: Helge Deller <deller@gmx.de>
Link: https://patchwork.freedesktop.org/patch/msgid/20230803184034.6456-3-tzimmermann@suse.de
drivers/video/fbdev/Kconfig
drivers/video/fbdev/acornfb.c

index 5f8392b4f2a1ea3f54f92caed87dec9e96d0c7f2..0863a2609e1ad938858df505238965521cb4ce08 100644 (file)
@@ -139,9 +139,7 @@ config FB_ARMCLCD
 config FB_ACORN
        bool "Acorn VIDC support"
        depends on (FB = y) && ARM && ARCH_ACORN
-       select FB_CFB_FILLRECT
-       select FB_CFB_COPYAREA
-       select FB_CFB_IMAGEBLIT
+       select FB_IOMEM_HELPERS
        help
          This is the frame buffer device driver for the Acorn VIDC graphics
          hardware found in Acorn RISC PCs and other ARM-based machines.  If
index 8fec21dfca0974e7678c8ce9b60c098cfed70b32..163d2c9f951c3a1610f7841a6e5d5a81a2211678 100644 (file)
@@ -605,13 +605,11 @@ acornfb_pan_display(struct fb_var_screeninfo *var, struct fb_info *info)
 
 static const struct fb_ops acornfb_ops = {
        .owner          = THIS_MODULE,
+       FB_IOMEM_DEFAULT_OPS,
        .fb_check_var   = acornfb_check_var,
        .fb_set_par     = acornfb_set_par,
        .fb_setcolreg   = acornfb_setcolreg,
        .fb_pan_display = acornfb_pan_display,
-       .fb_fillrect    = cfb_fillrect,
-       .fb_copyarea    = cfb_copyarea,
-       .fb_imageblit   = cfb_imageblit,
 };
 
 /*