hwrng: core - Convert sprintf/snprintf to sysfs_emit
authorLi Zhijian <lizhijian@fujitsu.com>
Thu, 14 Mar 2024 08:45:59 +0000 (16:45 +0800)
committerHerbert Xu <herbert@gondor.apana.org.au>
Tue, 2 Apr 2024 02:49:38 +0000 (10:49 +0800)
Per filesystems/sysfs.rst, show() should only use sysfs_emit()
or sysfs_emit_at() when formatting the value to be returned to user space.

coccinelle complains that there are still a couple of functions that use
snprintf(). Convert them to sysfs_emit().

sprintf() will be converted as weel if they have.

Generally, this patch is generated by
make coccicheck M=<path/to/file> MODE=patch \
COCCI=scripts/coccinelle/api/device_attr_show.cocci

No functional change intended

CC: Olivia Mackall <olivia@selenic.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: linux-crypto@vger.kernel.org
Signed-off-by: Li Zhijian <lizhijian@fujitsu.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/char/hw_random/core.c

index a3bbdd6e60fca2a75e48e2fa2cac86e329ae784c..f5c71a617a993108049f12de67234a39405c27c2 100644 (file)
@@ -382,7 +382,7 @@ static ssize_t rng_current_show(struct device *dev,
        if (IS_ERR(rng))
                return PTR_ERR(rng);
 
-       ret = snprintf(buf, PAGE_SIZE, "%s\n", rng ? rng->name : "none");
+       ret = sysfs_emit(buf, "%s\n", rng ? rng->name : "none");
        put_rng(rng);
 
        return ret;