cxl/acpi: Return 'rc' instead of '0' in cxl_parse_cfmws()
authorBreno Leitao <leitao@debian.org>
Fri, 14 Jul 2023 09:31:46 +0000 (02:31 -0700)
committerVishal Verma <vishal.l.verma@intel.com>
Tue, 18 Jul 2023 17:55:09 +0000 (11:55 -0600)
Driver initialization returned success (return 0) even if the
initialization (cxl_decoder_add() or acpi_table_parse_cedt()) failed.

Return the error instead of swallowing it.

Fixes: f4ce1f766f1e ("cxl/acpi: Convert CFMWS parsing to ACPI sub-table helpers")
Signed-off-by: Breno Leitao <leitao@debian.org>
Link: https://lore.kernel.org/r/20230714093146.2253438-2-leitao@debian.org
Reviewed-by: Alison Schofield <alison.schofield@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
drivers/cxl/acpi.c

index 33c073f0d7fe0fc236d58f6f612a635be3b10f37..d1c559879dcc00733cfb9abff6cffb64b0745659 100644 (file)
@@ -297,7 +297,7 @@ err_xormap:
                rc = cxl_decoder_autoremove(dev, cxld);
        if (rc) {
                dev_err(dev, "Failed to add decode range: %pr", res);
-               return 0;
+               return rc;
        }
        dev_dbg(dev, "add: %s node: %d range [%#llx - %#llx]\n",
                dev_name(&cxld->dev),