i3c: master: Add of_node_put() before return
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Tue, 23 Jul 2019 10:37:25 +0000 (16:07 +0530)
committerBoris Brezillon <boris.brezillon@collabora.com>
Sun, 11 Aug 2019 08:45:51 +0000 (10:45 +0200)
Each iteration of for_each_available_childe_of_node puts the previous
node, but in the case of a return from the middle of the loop, there
is no put, thus causing a memory leak. Add an of_node_put before the
return.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
drivers/i3c/master.c

index c58729081899326ddc66a4c7cc9fb9fa243aeef2..87d0f349dd37ad36a199486748d391fbe8e22ba5 100644 (file)
@@ -2048,8 +2048,10 @@ static int of_populate_i3c_bus(struct i3c_master_controller *master)
 
        for_each_available_child_of_node(i3cbus_np, node) {
                ret = of_i3c_master_add_dev(master, node);
-               if (ret)
+               if (ret) {
+                       of_node_put(node);
                        return ret;
+               }
        }
 
        /*