hwmon: (pmbus/mp2975) Correct comment inside 'mp2975_read_byte_data'
authorKonstantin Aladyshev <aladyshev22@gmail.com>
Sat, 27 Jan 2024 15:48:44 +0000 (18:48 +0300)
committerGuenter Roeck <linux@roeck-us.net>
Sat, 27 Jan 2024 16:03:18 +0000 (08:03 -0800)
The current driver code no longer perfrom internal conversion from
VID to direct. Instead it configures READ_VOUT using MFR_DC_LOOP_CTRL.
Correct the comment message inside the 'mp2975_read_byte_data'
function to match the driver logic.

Signed-off-by: Konstantin Aladyshev <aladyshev22@gmail.com>
Fixes: c60fe56c169e ("hwmon: (pmbus/mp2975) Fix driver initialization for MP2975 device")
Link: https://lore.kernel.org/r/20240127154844.989-1-aladyshev22@gmail.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/pmbus/mp2975.c

index 5bbfdacb61a769d5d8f8f1bfb68c6ebf8271eb6d..e5fa10b3b8bc7184e03e6caa0701e34f81bcb7cb 100644 (file)
@@ -131,10 +131,9 @@ static int mp2975_read_byte_data(struct i2c_client *client, int page, int reg)
        switch (reg) {
        case PMBUS_VOUT_MODE:
                /*
-                * Enforce VOUT direct format, since device allows to set the
-                * different formats for the different rails. Conversion from
-                * VID to direct provided by driver internally, in case it is
-                * necessary.
+                * Report direct format as configured by MFR_DC_LOOP_CTRL.
+                * Unlike on MP2971/MP2973 the reported VOUT_MODE isn't automatically
+                * internally updated, but always reads as PB_VOUT_MODE_VID.
                 */
                return PB_VOUT_MODE_DIRECT;
        default: