selftests: forwarding: Disable learning before link up
authorIdo Schimmel <idosch@nvidia.com>
Mon, 21 Mar 2022 17:51:01 +0000 (19:51 +0200)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 22 Mar 2022 10:09:24 +0000 (11:09 +0100)
Disable learning before bringing the bridge port up in order to avoid
the FDB being populated and the test failing.

Before:

 # ./bridge_locked_port.sh
 RTNETLINK answers: File exists
 TEST: Locked port ipv4                                              [FAIL]
         Ping worked after locking port, but before adding FDB entry
 TEST: Locked port ipv6                                              [ OK ]
 TEST: Locked port vlan                                              [ OK ]

After:

 # ./bridge_locked_port.sh
 TEST: Locked port ipv4                                              [ OK ]
 TEST: Locked port ipv6                                              [ OK ]
 TEST: Locked port vlan                                              [ OK ]

Fixes: b2b681a41251 ("selftests: forwarding: tests of locked port feature")
Signed-off-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
tools/testing/selftests/net/forwarding/bridge_locked_port.sh

index 6e98efa6d371286eb52f75aabc4590f0606dff18..67ce59bb355551bd669956314cf4b5fd1d38ba95 100755 (executable)
@@ -41,11 +41,11 @@ switch_create()
        ip link set dev $swp1 master br0
        ip link set dev $swp2 master br0
 
+       bridge link set dev $swp1 learning off
+
        ip link set dev br0 up
        ip link set dev $swp1 up
        ip link set dev $swp2 up
-
-       bridge link set dev $swp1 learning off
 }
 
 switch_destroy()