isofs: Remove calls to set/clear the error flag
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Sat, 20 Apr 2024 02:50:08 +0000 (03:50 +0100)
committerJan Kara <jack@suse.cz>
Tue, 23 Apr 2024 21:22:11 +0000 (23:22 +0200)
Nobody checks the error flag on isofs folios, so stop setting and
clearing it.

Cc: Jan Kara <jack@suse.cz>
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Jan Kara <jack@suse.cz>
Signed-off-by: Jan Kara <jack@suse.cz>
Message-Id: <20240420025029.2166544-14-willy@infradead.org>

fs/isofs/compress.c

index c4da3f634b92e23ca5ade630b8eb38eb8730b814..34d5baa5d88a003bb22752d51da2744875f81f5a 100644 (file)
@@ -346,8 +346,6 @@ static int zisofs_read_folio(struct file *file, struct folio *folio)
        for (i = 0; i < pcount; i++, index++) {
                if (i != full_page)
                        pages[i] = grab_cache_page_nowait(mapping, index);
-               if (pages[i])
-                       ClearPageError(pages[i]);
        }
 
        err = zisofs_fill_pages(inode, full_page, pcount, pages);
@@ -356,8 +354,6 @@ static int zisofs_read_folio(struct file *file, struct folio *folio)
        for (i = 0; i < pcount; i++) {
                if (pages[i]) {
                        flush_dcache_page(pages[i]);
-                       if (i == full_page && err)
-                               SetPageError(pages[i]);
                        unlock_page(pages[i]);
                        if (i != full_page)
                                put_page(pages[i]);