tests/test-char.c: Wait for the chardev to connect in char_socket_client_dupid_test
authorLukas Straub <lukasstraub2@web.de>
Mon, 28 Dec 2020 15:09:02 +0000 (16:09 +0100)
committerMarkus Armbruster <armbru@redhat.com>
Wed, 13 Jan 2021 09:21:17 +0000 (10:21 +0100)
A connecting chardev object has an additional reference by the connecting
thread, so if the chardev is still connecting by the end of the test,
then the chardev object won't be freed. This in turn means that the yank
instance won't be unregistered and when running the next test-case
yank_register_instance will abort, because the yank instance is
already/still registered.

Signed-off-by: Lukas Straub <lukasstraub2@web.de>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Message-Id: <1445e97a5800e3f2ba024ad52b500a0315701632.1609167865.git.lukasstraub2@web.de>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
tests/test-char.c

index 06102977b6feb5be67b28f49e05fff4cf9c3b02a..469d25989c540ecf89b511a22c9d09bf63176a54 100644 (file)
@@ -937,6 +937,7 @@ static void char_socket_client_dupid_test(gconstpointer opaque)
     g_assert_nonnull(opts);
     chr1 = qemu_chr_new_from_opts(opts, NULL, &error_abort);
     g_assert_nonnull(chr1);
+    qemu_chr_wait_connected(chr1, &error_abort);
 
     chr2 = qemu_chr_new_from_opts(opts, NULL, &local_err);
     g_assert_null(chr2);