staging: vt6656: Use BIT() macro instead of bit shift operator
authorOscar Carter <oscar.carter@gmx.com>
Tue, 14 Apr 2020 15:38:46 +0000 (17:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 16 Apr 2020 11:40:20 +0000 (13:40 +0200)
Use the BIT() macro instead of the bit left shift operator. So the code
is more clear.

It's safe to remove the casting to u16 type because the value obtained
never exceeds 16 bits. So the casting is unnecessary.

Signed-off-by: Oscar Carter <oscar.carter@gmx.com>
Link: https://lore.kernel.org/r/20200414153849.5785-3-oscar.carter@gmx.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vt6656/card.c

index 9bd37e57c7277f9e96a9effc6a2ccb4539b72324..f8bfadd4b5066554754846b2fcf8d676467b41ba 100644 (file)
@@ -228,7 +228,7 @@ void vnt_update_top_rates(struct vnt_private *priv)
 
        /*Determines the highest basic rate.*/
        for (i = RATE_54M; i >= RATE_6M; i--) {
-               if (priv->basic_rates & (u16)(1 << i)) {
+               if (priv->basic_rates & BIT(i)) {
                        top_ofdm = i;
                        break;
                }
@@ -237,7 +237,7 @@ void vnt_update_top_rates(struct vnt_private *priv)
        priv->top_ofdm_basic_rate = top_ofdm;
 
        for (i = RATE_11M;; i--) {
-               if (priv->basic_rates & (u16)(1 << i)) {
+               if (priv->basic_rates & BIT(i)) {
                        top_cck = i;
                        break;
                }