cxl/mbox: Remove useless cast in cxl_mem_create_range_info()
authorAlison Schofield <alison.schofield@intel.com>
Tue, 15 Aug 2023 17:20:52 +0000 (10:20 -0700)
committerDan Williams <dan.j.williams@intel.com>
Tue, 24 Oct 2023 23:04:10 +0000 (16:04 -0700)
DEFINE_RES_MEM() is a wrapper around the DEFINE_RES_NAMED() macro
which already has the (struct resource) for the compound literal.
The user of the macro should not repeat the cast.

Cleans up these sparse warnings:
drivers/cxl/core/mbox.c:1184:18: warning: cast to non-scalar
drivers/cxl/core/mbox.c:1184:18: warning: cast from non-scalar

Fixes: 52c4d11f1dce ("resource: Convert DEFINE_RES_NAMED() to be compound literal")
Signed-off-by: Alison Schofield <alison.schofield@intel.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Reviewed-by: Davidlohr Bueso <dave@stgolabs.net>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20230815172052.22514-1-alison.schofield@intel.com
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/cxl/core/mbox.c

index 4df4f614f490ef96d26f412a9cff42e52d246486..f1fe689fc53fa85cb4fe6e5241cde1cdb76fa5af 100644 (file)
@@ -1224,8 +1224,7 @@ int cxl_mem_create_range_info(struct cxl_memdev_state *mds)
                return 0;
        }
 
-       cxlds->dpa_res =
-               (struct resource)DEFINE_RES_MEM(0, mds->total_bytes);
+       cxlds->dpa_res = DEFINE_RES_MEM(0, mds->total_bytes);
 
        if (mds->partition_align_bytes == 0) {
                rc = add_dpa_res(dev, &cxlds->dpa_res, &cxlds->ram_res, 0,