ASoC: amd: ps: Fix -Wformat-truncation warning
authorTakashi Iwai <tiwai@suse.de>
Fri, 15 Sep 2023 08:22:07 +0000 (10:22 +0200)
committerMark Brown <broonie@kernel.org>
Fri, 15 Sep 2023 12:16:25 +0000 (13:16 +0100)
The compile warning with -Wformat-truncation at
sdw_amd_scan_controller() is false-positive; the max loop size is
AMD_SDW_MAX_MANAGERS (= 2), hence it fits with the given size.

For suppressing the warning, replace snprintf() with scnprintf().
As stated in the above, truncation doesn't matter.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://lore.kernel.org/r/20230915082207.26200-1-tiwai@suse.de
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/ps/pci-ps.c

index 4af3c3665387db88d74c6f07e18430710b394c90..7e4c0ec9e56ccd9444ea80c461e72a43dc40e4b9 100644 (file)
@@ -274,7 +274,7 @@ static int sdw_amd_scan_controller(struct device *dev)
        dev_dbg(dev, "ACPI reports %d SoundWire Manager devices\n", count);
        acp_data->sdw_manager_count = count;
        for (index = 0; index < count; index++) {
-               snprintf(name, sizeof(name), "mipi-sdw-link-%d-subproperties", index);
+               scnprintf(name, sizeof(name), "mipi-sdw-link-%d-subproperties", index);
                link = fwnode_get_named_child_node(acp_data->sdw_fw_node, name);
                if (!link) {
                        dev_err(dev, "Manager node %s not found\n", name);