net_sched: move from strlcpy with unused retval to strscpy
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Thu, 18 Aug 2022 21:02:28 +0000 (23:02 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 23 Aug 2022 01:07:26 +0000 (18:07 -0700)
Follow the advice of the below link and prefer 'strscpy' in this
subsystem. Conversion is 1:1 because the return value is not used.
Generated by a coccinelle script.

Link: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://lore.kernel.org/r/20220818210228.8635-1-wsa+renesas@sang-engineering.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/sched/sch_api.c
net/sched/sch_teql.c

index 90868a84a4a23714647202be39d2c180ba72891b..9f7680728e2b3b0c6473538a1f5f99ec2db16563 100644 (file)
@@ -195,7 +195,7 @@ EXPORT_SYMBOL(unregister_qdisc);
 void qdisc_get_default(char *name, size_t len)
 {
        read_lock(&qdisc_mod_lock);
-       strlcpy(name, default_qdisc_ops->id, len);
+       strscpy(name, default_qdisc_ops->id, len);
        read_unlock(&qdisc_mod_lock);
 }
 
index 6af6b95bdb6723a3d600c1defae08fd897c7a308..1f447b77ce8452d90623bcf3db38553ec1051477 100644 (file)
@@ -492,7 +492,7 @@ static int __init teql_init(void)
 
                master = netdev_priv(dev);
 
-               strlcpy(master->qops.id, dev->name, IFNAMSIZ);
+               strscpy(master->qops.id, dev->name, IFNAMSIZ);
                err = register_qdisc(&master->qops);
 
                if (err) {