arm64/sme: Ensure that all fields in SMCR_EL1 are set to known values
authorMark Brown <broonie@kernel.org>
Tue, 13 Feb 2024 15:32:46 +0000 (15:32 +0000)
committerCatalin Marinas <catalin.marinas@arm.com>
Thu, 22 Feb 2024 19:39:34 +0000 (19:39 +0000)
At present nothing in our CPU initialisation code ever sets unknown fields
in SMCR_EL1 to known values, all updates to SMCR_EL1 are read/modify/write
sequences. All the unknown fields are RES0, explicitly initialise them as
such to avoid future surprises.

Signed-off-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20240213-arm64-fp-init-vec-cr-v1-2-7e7c2d584f26@kernel.org
Signed-off-by: Catalin Marinas <catalin.marinas@arm.com>
arch/arm64/kernel/fpsimd.c

index cc3c9ad877a8c0be09a42ef44ef7fec69628f726..f96907b813fa75d2563a8cd9af427a158c002941 100644 (file)
@@ -1247,6 +1247,9 @@ void cpu_enable_sme(const struct arm64_cpu_capabilities *__always_unused p)
        write_sysreg(read_sysreg(CPACR_EL1) | CPACR_EL1_SMEN_EL1EN, CPACR_EL1);
        isb();
 
+       /* Ensure all bits in SMCR are set to known values */
+       write_sysreg_s(0, SYS_SMCR_EL1);
+
        /* Allow EL0 to access TPIDR2 */
        write_sysreg(read_sysreg(SCTLR_EL1) | SCTLR_ELx_ENTP2, SCTLR_EL1);
        isb();