staging: vc04_services: vchiq_arm: Use %p to log pointer address
authorUmang Jain <umang.jain@ideasonboard.com>
Thu, 7 Dec 2023 08:38:36 +0000 (14:08 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 9 Dec 2023 14:06:35 +0000 (15:06 +0100)
Solves the following Smatch warnings:
service_callback() warn: argument 7 to %lx specifier is cast from pointer
service_callback() warn: argument 11 to %lx specifier is cast from pointer
service_callback() warn: argument 12 to %lx specifier is cast from pointer
service_callback() warn: argument 13 to %lx specifier is cast from pointer

%p will print the hashed pointer to dynamic debug.
In order to print the unmodified pointer address, one can use the
`no_hash_pointers` via kernel parameters.

Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
Link: https://lore.kernel.org/r/20231207083837.153843-2-umang.jain@ideasonboard.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c

index 4b4ff469d3a31643076f5a9cee6a9e676ff2abc6..1579bd4e5263cb9c5f238184f18bbd304f9efcb0 100644 (file)
@@ -1088,10 +1088,9 @@ service_callback(struct vchiq_instance *instance, enum vchiq_reason reason,
        rcu_read_unlock();
 
        dev_dbg(service->state->dev,
-               "arm: service %lx(%d,%p), reason %d, header %lx, instance %lx, bulk_userdata %lx\n",
-               (unsigned long)user_service, service->localport,
-               user_service->userdata, reason, (unsigned long)header,
-               (unsigned long)instance, (unsigned long)bulk_userdata);
+               "arm: service %p(%d,%p), reason %d, header %p, instance %p, bulk_userdata %p\n",
+               user_service, service->localport, user_service->userdata,
+               reason, header, instance, bulk_userdata);
 
        if (header && user_service->is_vchi) {
                spin_lock(&msg_queue_spinlock);