spi: Drop warning from spi_stop_queue()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sat, 16 Sep 2023 16:12:35 +0000 (18:12 +0200)
committerMark Brown <broonie@kernel.org>
Mon, 18 Sep 2023 12:05:29 +0000 (13:05 +0100)
Both callers of spi_stop_queue() (i.e. spi_destroy_queue() and
spi_controller_suspend()) already emit an error message if
spi_stop_queue() fails. Another warning in this case isn't helpful, so
drop it.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230916161235.1050176-1-u.kleine-koenig@pengutronix.de
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi.c

index 8d6304cb061ec9012be01fc0b3b4e9df5f942bd8..ac518be34917bf54cca96e3de0ca44374804b7d2 100644 (file)
@@ -2093,10 +2093,6 @@ static int spi_stop_queue(struct spi_controller *ctlr)
 
        spin_unlock_irqrestore(&ctlr->queue_lock, flags);
 
-       if (ret) {
-               dev_warn(&ctlr->dev, "could not stop message queue\n");
-               return ret;
-       }
        return ret;
 }