qapi: restrict allow-oob value to be "true"
authorPeter Xu <peterx@redhat.com>
Mon, 26 Mar 2018 06:38:57 +0000 (14:38 +0800)
committerEric Blake <eblake@redhat.com>
Tue, 27 Mar 2018 15:17:45 +0000 (10:17 -0500)
It was missed in the first version of OOB series.  We should check this
to make sure we throw the right error when fault value is passed in.

Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20180326063901.27425-5-peterx@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Eric Blake <eblake@redhat.com>
scripts/qapi/common.py

index 2c05e3c2845deeb15de356c547d712cdbd817e9d..3e14bc41f2c05e846d1e780a5275cee392cdb2de 100644 (file)
@@ -872,7 +872,7 @@ def check_keys(expr_elem, meta, required, optional=[]):
             raise QAPISemError(info,
                                "'%s' of %s '%s' should only use false value"
                                % (key, meta, name))
-        if key == 'boxed' and value is not True:
+        if (key == 'boxed' or key == 'allow-oob') and value is not True:
             raise QAPISemError(info,
                                "'%s' of %s '%s' should only use true value"
                                % (key, meta, name))