accel/habanalabs: call put_pid after hpriv list is updated
authorKoby Elbaz <kelbaz@habana.ai>
Tue, 6 Jun 2023 08:57:51 +0000 (11:57 +0300)
committerOded Gabbay <ogabbay@kernel.org>
Mon, 9 Oct 2023 09:37:18 +0000 (12:37 +0300)
Because we might still be using related resources, decrementing PID's
reference count should be done at later stages of the device release.
A good place is right after the representing private structure is
removed from LKD's list.

Signed-off-by: Koby Elbaz <kelbaz@habana.ai>
Reviewed-by: Oded Gabbay <ogabbay@kernel.org>
Signed-off-by: Oded Gabbay <ogabbay@kernel.org>
drivers/accel/habanalabs/common/device.c

index 764d40c0d6664fcfe348fe5a4756ad39d257a94d..c61a58a2e622e9c54bb4d187eeaeb797956a7006 100644 (file)
@@ -408,8 +408,6 @@ static void hpriv_release(struct kref *ref)
 
        hdev->asic_funcs->send_device_activity(hdev, false);
 
-       put_pid(hpriv->taskpid);
-
        hl_debugfs_remove_file(hpriv);
 
        mutex_destroy(&hpriv->ctx_lock);
@@ -448,6 +446,8 @@ static void hpriv_release(struct kref *ref)
        list_del(&hpriv->dev_node);
        mutex_unlock(&hdev->fpriv_list_lock);
 
+       put_pid(hpriv->taskpid);
+
        if (reset_device) {
                hl_device_reset(hdev, HL_DRV_RESET_DEV_RELEASE);
        } else {