hw/arm/virt: Remove null-check in virt_build_smbios()
authorPhilippe Mathieu-Daudé <philmd@redhat.com>
Sat, 9 Mar 2019 18:19:19 +0000 (19:19 +0100)
committerLaurent Vivier <laurent@vivier.eu>
Mon, 11 Mar 2019 17:48:20 +0000 (18:48 +0100)
Since commit 578f3c7b0835 ("arm: add fw_cfg to "virt" board",
2014-12-22), the machvirt_init() unconditionally creates the
fw_cfg object.  Later, commit c30e15658b1b ("smbios: implement
smbios support for mach-virt", 2015-09-07) added a superfluous
null-check on it.
Remove this superfluous check.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-Id: <20190309181920.30553-2-philmd@redhat.com>
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
hw/arm/virt.c

index 7f66ddad89f6f5729861bb0632e4bb6485296c1c..377e95a4cdb08441f1c5d1da876149e211baaae5 100644 (file)
@@ -1281,10 +1281,6 @@ static void virt_build_smbios(VirtMachineState *vms)
     size_t smbios_tables_len, smbios_anchor_len;
     const char *product = "QEMU Virtual Machine";
 
-    if (!vms->fw_cfg) {
-        return;
-    }
-
     if (kvm_enabled()) {
         product = "KVM Virtual Machine";
     }