spi: amd: Fix speed selection
authorShreeya Patel <shreeya.patel@collabora.com>
Tue, 30 Aug 2022 09:36:07 +0000 (15:06 +0530)
committerMark Brown <broonie@kernel.org>
Tue, 30 Aug 2022 10:21:34 +0000 (11:21 +0100)
If the current speed is equal to the requested speed by the device
then return success.
This patch fixes a bug introduced by the commit 3fe26121dc3a
("spi: amd: Configure device speed") which checks speed_hz instead
of amd_spi->speed_hz.

Fixes: 3fe26121dc3a ("spi: amd: Configure device speed")
Signed-off-by: Shreeya Patel <shreeya.patel@collabora.com>
Link: https://lore.kernel.org/r/20220830093607.45484-1-shreeya.patel@collabora.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-amd.c

index 264633c5ce0bd3bfd4c088fa49ef31cbc379b9d0..e23121456c706a3cd43e0821e5beca46a045fb61 100644 (file)
@@ -240,9 +240,6 @@ static int amd_set_spi_freq(struct amd_spi *amd_spi, u32 speed_hz)
 {
        unsigned int i, spd7_val, alt_spd;
 
-       if (speed_hz == amd_spi->speed_hz)
-               return 0;
-
        if (speed_hz < AMD_SPI_MIN_HZ)
                return -EINVAL;
 
@@ -250,7 +247,7 @@ static int amd_set_spi_freq(struct amd_spi *amd_spi, u32 speed_hz)
                if (speed_hz >= amd_spi_freq[i].speed_hz)
                        break;
 
-       if (speed_hz == amd_spi_freq[i].speed_hz)
+       if (amd_spi->speed_hz == amd_spi_freq[i].speed_hz)
                return 0;
 
        amd_spi->speed_hz = amd_spi_freq[i].speed_hz;