net: ethtool: reject unsupported RSS input xfrm values

RXFH input_xfrm currently has three supported values: 0 (clear all),
symmetric_xor and NO_CHANGE.

Reject any other value sent from user-space.

Fixes: 13e59344fb9d ("net: ethtool: add support for symmetric-xor RSS hash")
Suggested-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Ahmed Zaki <ahmed.zaki@intel.com>
Link: https://lore.kernel.org/r/20240104212653.394424-1-ahmed.zaki@intel.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/ethtool/ioctl.c b/net/ethtool/ioctl.c
index 4bc9a2a07bbb3faafc6dcaecacb18d8d1951217f..7519b0818b913a494e81de3980f577e6deb902d0 100644 (file)
--- a/net/ethtool/ioctl.c
+++ b/net/ethtool/ioctl.c
@@ -1302,6 +1302,9 @@ static noinline_for_stack int ethtool_set_rxfh(struct net_device *dev,
        if (rxfh.rss_context && !ops->cap_rss_ctx_supported)
                return -EOPNOTSUPP;
        /* Check input data transformation capabilities */
+       if (rxfh.input_xfrm && rxfh.input_xfrm != RXH_XFRM_SYM_XOR &&
+           rxfh.input_xfrm != RXH_XFRM_NO_CHANGE)
+               return -EINVAL;
        if ((rxfh.input_xfrm & RXH_XFRM_SYM_XOR) &&
            !ops->cap_rss_sym_xor_supported)
                return -EOPNOTSUPP;