source, tpl: Fix staticcheck complaints

tpl/template_funcs.go:1019:3: the surrounding loop is unconditionally terminated
source/lazy_file_reader.go:66:5: err != nil is always true for all possible
values ([nil:error] != [nil:error])

diff --git a/source/lazy_file_reader.go b/source/lazy_file_reader.go
index 8ebe8df211aef846aacd742d2b3ad6745db75492..7cc484f0b5e498184b42d1b3391ba7dd3b3a135f 100644 (file)
--- a/source/lazy_file_reader.go
+++ b/source/lazy_file_reader.go
@@ -62,8 +62,7 @@ func (l *LazyFileReader) Read(p []byte) (n int, err error) {
                }
                l.contents = bytes.NewReader(b)
        }
-       l.contents.Seek(l.pos, 0)
-       if err != nil {
+       if _, err = l.contents.Seek(l.pos, 0); err != nil {
                return 0, errors.New("failed to set read position: " + err.Error())
        }
        n, err = l.contents.Read(p)

diff --git a/tpl/template_funcs.go b/tpl/template_funcs.go
index 281e5cd643add766d885182e4917b94f5ff28472..d9b4be99028fc1cd8d5e55de3cc90455e24cd241 100644 (file)
--- a/tpl/template_funcs.go
+++ b/tpl/template_funcs.go
@@ -1010,13 +1010,13 @@ func delimit(seq, delimiter interface{}, last ...interface{}) (template.HTML, er
        }
 
        var dLast *string
-       for _, l := range last {
+       if len(last) > 0 {
+               l := last[0]
                dStr, err := cast.ToStringE(l)
                if err != nil {
                        dLast = nil
                }
                dLast = &dStr
-               break
        }
 
        seqv := reflect.ValueOf(seq)