phy: qcom: phy-qcom-m31: fix wrong pointer pass to PTR_ERR()
authorYang Yingliang <yangyingliang@huawei.com>
Thu, 24 Aug 2023 09:13:45 +0000 (17:13 +0800)
committerVinod Koul <vkoul@kernel.org>
Wed, 7 Feb 2024 10:20:26 +0000 (11:20 +0100)
It should be 'qphy->vreg' passed to PTR_ERR() when devm_regulator_get() fails.

Fixes: 08e49af50701 ("phy: qcom: Introduce M31 USB PHY driver")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Varadarajan Narayanan <quic_varada@quicinc.com>
Link: https://lore.kernel.org/r/20230824091345.1072650-1-yangyingliang@huawei.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/phy/qualcomm/phy-qcom-m31.c

index c2590579190a935d76abc9cde99964c9958d3d07..03fb0d4b75d744492e4646af65287f61e7927f1b 100644 (file)
@@ -299,7 +299,7 @@ static int m31usb_phy_probe(struct platform_device *pdev)
 
        qphy->vreg = devm_regulator_get(dev, "vdda-phy");
        if (IS_ERR(qphy->vreg))
-               return dev_err_probe(dev, PTR_ERR(qphy->phy),
+               return dev_err_probe(dev, PTR_ERR(qphy->vreg),
                                     "failed to get vreg\n");
 
        phy_set_drvdata(qphy->phy, qphy);