amd/amdgpu: use kmalloc_array to replace kmalloc with multiply
authorBernard Zhao <bernard@vivo.com>
Wed, 18 Nov 2020 02:55:01 +0000 (18:55 -0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 24 Nov 2020 17:04:39 +0000 (12:04 -0500)
Fix check_patch.pl warning:
WARNING: Prefer kmalloc_array over kmalloc with multiply
+bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL);
WARNING: Prefer kmalloc_array over kmalloc with multiply
+bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo),
GFP_KERNEL);
kmalloc_array has multiply overflow check, which will be safer.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Bernard Zhao <bernard@vivo.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c

index a36c648bbe91bd63e3a1f4b274a91e83188b25e4..9cb96e4ff14c01c10295ed47d0b6386a9f08f925 100644 (file)
@@ -280,8 +280,8 @@ static int amdgpu_virt_init_ras_err_handler_data(struct amdgpu_device *adev)
        if (!*data)
                return -ENOMEM;
 
-       bps = kmalloc(align_space * sizeof((*data)->bps), GFP_KERNEL);
-       bps_bo = kmalloc(align_space * sizeof((*data)->bps_bo), GFP_KERNEL);
+       bps = kmalloc_array(align_space, sizeof((*data)->bps), GFP_KERNEL);
+       bps_bo = kmalloc_array(align_space, sizeof((*data)->bps_bo), GFP_KERNEL);
 
        if (!bps || !bps_bo) {
                kfree(bps);