wifi: ath5k: Use platform_get_irq() to get the interrupt
authorDouglas Anderson <dianders@chromium.org>
Wed, 1 Feb 2023 16:54:43 +0000 (08:54 -0800)
committerKalle Valo <quic_kvalo@quicinc.com>
Wed, 22 Feb 2023 09:51:43 +0000 (11:51 +0200)
As of commit a1a2b7125e10 ("of/platform: Drop static setup of IRQ
resource from DT core"), we need to use platform_get_irq() instead of
platform_get_resource() to get our IRQs because
platform_get_resource() simply won't get them anymore.

This was already fixed in several other Atheros WiFi drivers,
apparently in response to Zeal Robot reports. An example of another
fix is commit 9503a1fc123d ("ath9k: Use platform_get_irq() to get the
interrupt"). ath5k seems to have been missed in this effort, though.

Fixes: a1a2b7125e10 ("of/platform: Drop static setup of IRQ resource from DT core")
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Signed-off-by: Kalle Valo <quic_kvalo@quicinc.com>
Link: https://lore.kernel.org/r/20230201084131.v2.2.Ic4f8542b0588d7eb4bc6e322d4af3d2064e84ff0@changeid
drivers/net/wireless/ath/ath5k/ahb.c

index 2c9cec8b53d9e22a2e7683b92ac0feb23593fc2d..28a1e5eff204eb2e5b0022674847872fa40f1841 100644 (file)
@@ -113,15 +113,13 @@ static int ath_ahb_probe(struct platform_device *pdev)
                goto err_out;
        }
 
-       res = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (res == NULL) {
-               dev_err(&pdev->dev, "no IRQ resource found\n");
-               ret = -ENXIO;
+       irq = platform_get_irq(pdev, 0);
+       if (irq < 0) {
+               dev_err(&pdev->dev, "no IRQ resource found: %d\n", irq);
+               ret = irq;
                goto err_iounmap;
        }
 
-       irq = res->start;
-
        hw = ieee80211_alloc_hw(sizeof(struct ath5k_hw), &ath5k_hw_ops);
        if (hw == NULL) {
                dev_err(&pdev->dev, "no memory for ieee80211_hw\n");