selftests/memory-hotplug: Adjust log info for maintainability
authorZhao Gongyi <zhaogongyi@huawei.com>
Fri, 30 Sep 2022 06:35:26 +0000 (14:35 +0800)
committerShuah Khan <skhan@linuxfoundation.org>
Fri, 7 Oct 2022 16:32:10 +0000 (10:32 -0600)
Redirect misleading error message to /dev/null for
offline_memory_expect_success(), And, add an output
for online->offline test.

Signed-off-by: Zhao Gongyi <zhaogongyi@huawei.com>
Acked-by: David Hildenbrand <david@redhat.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/memory-hotplug/mem-on-off-test.sh

index 91a7457616bb500a6fd75485824bb36c29bc16f0..74ee5067a8ce286fbb12c3d93456ab66834d8adb 100755 (executable)
@@ -207,8 +207,11 @@ echo -e "\t trying to offline $target out of $hotpluggable_num memory block(s):"
 for memory in `hotpluggable_online_memory`; do
        if [ "$target" -gt 0 ]; then
                echo "online->offline memory$memory"
-               if offline_memory_expect_success $memory; then
+               if offline_memory_expect_success $memory &>/dev/null; then
                        target=$(($target - 1))
+                       echo "-> Success"
+               else
+                       echo "-> Failure"
                fi
        fi
 done
@@ -267,7 +270,7 @@ prerequisite_extra
 echo 0 > $NOTIFIER_ERR_INJECT_DIR/actions/MEM_GOING_OFFLINE/error
 for memory in `hotpluggable_online_memory`; do
        if [ $((RANDOM % 100)) -lt $ratio ]; then
-               offline_memory_expect_success $memory
+               offline_memory_expect_success $memory &>/dev/null
        fi
 done