xfs: rearrange xfs_inode_walk_ag parameters
authorDarrick J. Wong <darrick.wong@oracle.com>
Thu, 21 May 2020 20:08:50 +0000 (13:08 -0700)
committerDarrick J. Wong <darrick.wong@oracle.com>
Wed, 27 May 2020 15:49:28 +0000 (08:49 -0700)
The perag structure already has a pointer to the xfs_mount, so we don't
need to pass that separately and can drop it.  Having done that, move
iter_flags so that the argument order is the same between xfs_inode_walk
and xfs_inode_walk_ag.  The latter will make things less confusing for a
future patch that enables background scanning work to be done in
parallel.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Brian Foster <bfoster@redhat.com>
fs/xfs/xfs_icache.c

index 82e70b9f25607a7b03c3bcec98a751336b3493e4..0a5ac6f9a583491a3aa635291032e4764ebd68a4 100644 (file)
@@ -817,13 +817,13 @@ out_unlock_noent:
  */
 STATIC int
 xfs_inode_walk_ag(
-       struct xfs_mount        *mp,
        struct xfs_perag        *pag,
+       int                     iter_flags,
        int                     (*execute)(struct xfs_inode *ip, void *args),
        void                    *args,
-       int                     tag,
-       int                     iter_flags)
+       int                     tag)
 {
+       struct xfs_mount        *mp = pag->pag_mount;
        uint32_t                first_index;
        int                     last_error = 0;
        int                     skipped;
@@ -952,8 +952,7 @@ xfs_inode_walk(
        ag = 0;
        while ((pag = xfs_inode_walk_get_perag(mp, ag, tag))) {
                ag = pag->pag_agno + 1;
-               error = xfs_inode_walk_ag(mp, pag, execute, args, tag,
-                               iter_flags);
+               error = xfs_inode_walk_ag(pag, iter_flags, execute, args, tag);
                xfs_perag_put(pag);
                if (error) {
                        last_error = error;