net/mlx5: Set devlink reload feature bit for supported devices only
authorLeon Romanovsky <leonro@nvidia.com>
Tue, 12 Oct 2021 13:15:25 +0000 (16:15 +0300)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Oct 2021 23:29:17 +0000 (16:29 -0700)
Mulitport slave device doesn't support devlink reload, so instead of
complicating initialization flow with devlink_reload_enable() which
will be removed in next patch, don't set DEVLINK_F_RELOAD feature bit
for such devices.

This fixes an error when reload counters exposed (and equal zero) for
the mode that is not supported at all.

Fixes: d89ddaae1766 ("net/mlx5: Disable devlink reload for multi port slave device")
Signed-off-by: Leon Romanovsky <leonro@nvidia.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/devlink.c

index fa98b7b9599006ec6b789ccef698e4998044be3e..a85341a41cd001d060dfa7506d262b8d753c8a1d 100644 (file)
@@ -796,6 +796,7 @@ static void mlx5_devlink_traps_unregister(struct devlink *devlink)
 
 int mlx5_devlink_register(struct devlink *devlink)
 {
+       struct mlx5_core_dev *dev = devlink_priv(devlink);
        int err;
 
        err = devlink_params_register(devlink, mlx5_devlink_params,
@@ -813,7 +814,9 @@ int mlx5_devlink_register(struct devlink *devlink)
        if (err)
                goto traps_reg_err;
 
-       devlink_set_features(devlink, DEVLINK_F_RELOAD);
+       if (!mlx5_core_is_mp_slave(dev))
+               devlink_set_features(devlink, DEVLINK_F_RELOAD);
+
        return 0;
 
 traps_reg_err: