selftests:x86: Fix Format String Warnings in lam.c
authorangquan yu <angquan21@gmail.com>
Wed, 29 Nov 2023 03:36:15 +0000 (21:36 -0600)
committerShuah Khan <skhan@linuxfoundation.org>
Thu, 30 Nov 2023 21:32:41 +0000 (14:32 -0700)
This commit addresses compiler warnings in lam.c related to the usage
of non-literal format strings without format arguments in the
'run_test' function.

Warnings fixed:
- Resolved warnings indicating that 'ksft_test_result_skip' and
'ksft_test_result' were called with 't->msg' as a format string without
accompanying format arguments.

Changes made:
- Modified the calls to 'ksft_test_result_skip' and 'ksft_test_result'
to explicitly include a format specifier ("%s") for 't->msg'.
- This ensures that the string is safely treated as a format argument,
adhering to safer coding practices and resolving the compiler warnings.

Signed-off-by: angquan yu <angquan21@gmail.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
tools/testing/selftests/x86/lam.c

index 8f9b06d9ce039ab61a8c9ba2d5a3a33c02a85828..215b8150b7ccad447b5369b39b34a1bdae42ee85 100644 (file)
@@ -817,7 +817,7 @@ static void run_test(struct testcases *test, int count)
 
                /* return 3 is not support LA57, the case should be skipped */
                if (ret == 3) {
-                       ksft_test_result_skip(t->msg);
+                       ksft_test_result_skip("%s", t->msg);
                        continue;
                }
 
@@ -826,7 +826,7 @@ static void run_test(struct testcases *test, int count)
                else
                        ret = !(t->expected);
 
-               ksft_test_result(ret, t->msg);
+               ksft_test_result(ret, "%s", t->msg);
        }
 }