Bluetooth: L2CAP: Fix possible multiple reject send
authorFrédéric Danis <frederic.danis@collabora.com>
Tue, 19 Dec 2023 08:10:22 +0000 (09:10 +0100)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Fri, 22 Dec 2023 17:59:46 +0000 (12:59 -0500)
In case of an incomplete command or a command with a null identifier 2
reject packets will be sent, one with the identifier and one with 0.
Consuming the data of the command will prevent it.
This allows to send a reject packet for each corrupted command in a
multi-command packet.

Signed-off-by: Frédéric Danis <frederic.danis@collabora.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
net/bluetooth/l2cap_core.c

index baeebee41cd9e8c137aad8063dd224d24f72349a..60298975d5c45620f21ca5fe161da1a9fdf55eec 100644 (file)
@@ -6526,7 +6526,8 @@ static inline void l2cap_sig_channel(struct l2cap_conn *conn,
                if (len > skb->len || !cmd->ident) {
                        BT_DBG("corrupted command");
                        l2cap_sig_send_rej(conn, cmd->ident);
-                       break;
+                       skb_pull(skb, len > skb->len ? skb->len : len);
+                       continue;
                }
 
                err = l2cap_bredr_sig_cmd(conn, cmd, len, skb->data);