dma-direct: re-encrypt memory if dma_direct_alloc_pages() fails
authorDavid Rientjes <rientjes@google.com>
Thu, 11 Jun 2020 19:20:29 +0000 (12:20 -0700)
committerChristoph Hellwig <hch@lst.de>
Wed, 17 Jun 2020 07:29:38 +0000 (09:29 +0200)
If arch_dma_set_uncached() fails after memory has been decrypted, it needs
to be re-encrypted before freeing.

Fixes: fa7e2247c572 ("dma-direct: make uncached_kernel_address more general")
Signed-off-by: David Rientjes <rientjes@google.com>
Signed-off-by: Christoph Hellwig <hch@lst.de>
kernel/dma/direct.c

index c93e3c8e3d01d630b612fb3f36e8ffe3fc19370e..80d33f215a2ebbbb784453b8e959b808c373d82a 100644 (file)
@@ -220,7 +220,7 @@ void *dma_direct_alloc_pages(struct device *dev, size_t size,
                arch_dma_prep_coherent(page, size);
                ret = arch_dma_set_uncached(ret, size);
                if (IS_ERR(ret))
-                       goto out_free_pages;
+                       goto out_encrypt_pages;
        }
 done:
        if (force_dma_unencrypted(dev))
@@ -228,6 +228,11 @@ done:
        else
                *dma_handle = phys_to_dma(dev, page_to_phys(page));
        return ret;
+
+out_encrypt_pages:
+       if (force_dma_unencrypted(dev))
+               set_memory_encrypted((unsigned long)page_address(page),
+                                    1 << get_order(size));
 out_free_pages:
        dma_free_contiguous(dev, page, size);
        return NULL;