crypto: arm64/aes-cipher - move S-box to .rodata section
authorArd Biesheuvel <ard.biesheuvel@linaro.org>
Wed, 10 Jan 2018 12:11:37 +0000 (12:11 +0000)
committerHerbert Xu <herbert@gondor.apana.org.au>
Thu, 18 Jan 2018 12:00:30 +0000 (23:00 +1100)
Move the AES inverse S-box to the .rodata section where it is safe from
abuse by speculation.

Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
arch/arm64/crypto/aes-cipher-core.S

index 6d2445d603cc244e4cd08acf420ae8b8089e5d88..3a44eada23477e0ef48f4adc14dde1a800d4bb5c 100644 (file)
@@ -125,6 +125,16 @@ CPU_BE(    rev             w7, w7          )
        ret
        .endm
 
+ENTRY(__aes_arm64_encrypt)
+       do_crypt        fround, crypto_ft_tab, crypto_ft_tab + 1, 2
+ENDPROC(__aes_arm64_encrypt)
+
+       .align          5
+ENTRY(__aes_arm64_decrypt)
+       do_crypt        iround, crypto_it_tab, __aes_arm64_inverse_sbox, 0
+ENDPROC(__aes_arm64_decrypt)
+
+       .section        ".rodata", "a"
        .align          L1_CACHE_SHIFT
        .type           __aes_arm64_inverse_sbox, %object
 __aes_arm64_inverse_sbox:
@@ -161,12 +171,3 @@ __aes_arm64_inverse_sbox:
        .byte           0x17, 0x2b, 0x04, 0x7e, 0xba, 0x77, 0xd6, 0x26
        .byte           0xe1, 0x69, 0x14, 0x63, 0x55, 0x21, 0x0c, 0x7d
        .size           __aes_arm64_inverse_sbox, . - __aes_arm64_inverse_sbox
-
-ENTRY(__aes_arm64_encrypt)
-       do_crypt        fround, crypto_ft_tab, crypto_ft_tab + 1, 2
-ENDPROC(__aes_arm64_encrypt)
-
-       .align          5
-ENTRY(__aes_arm64_decrypt)
-       do_crypt        iround, crypto_it_tab, __aes_arm64_inverse_sbox, 0
-ENDPROC(__aes_arm64_decrypt)