net: ax88796c: Remove pointless check in ax88796c_open()

Clang warns:

drivers/net/ethernet/asix/ax88796c_main.c:851:24: error: address of
array 'ax_local->phydev->advertising' will always evaluate to 'true'
[-Werror,-Wpointer-bool-conversion]
        if (ax_local->phydev->advertising &&
            ~~~~~~~~~~~~~~~~~~^~~~~~~~~~~ ~~

advertising cannot be NULL here if ax_local is not NULL, which cannot
happen due to the check in ax88796c_probe(). Remove the check.

Link: https://github.com/ClangBuiltLinux/linux/issues/1492
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/net/ethernet/asix/ax88796c_main.c b/drivers/net/ethernet/asix/ax88796c_main.c
index 3f25fafd422ed22d6896516e05099e493fc0f299..4b0c5a09fd57ffbdaadecab84f71c1a26429f4f3 100644 (file)
--- a/drivers/net/ethernet/asix/ax88796c_main.c
+++ b/drivers/net/ethernet/asix/ax88796c_main.c
@@ -850,11 +850,10 @@ ax88796c_open(struct net_device *ndev)
        /* Setup flow-control configuration */
        phy_support_asym_pause(ax_local->phydev);
 
-       if (ax_local->phydev->advertising &&
-           (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
-                              ax_local->phydev->advertising) ||
-            linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
-                              ax_local->phydev->advertising)))
+       if (linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,
+                             ax_local->phydev->advertising) ||
+           linkmode_test_bit(ETHTOOL_LINK_MODE_Asym_Pause_BIT,
+                             ax_local->phydev->advertising))
                fc |= AX_FC_ANEG;
 
        fc |= linkmode_test_bit(ETHTOOL_LINK_MODE_Pause_BIT,