drm: bridge: thc63lvd1024: Print error message when DT parsing fails
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 18 Mar 2024 16:06:01 +0000 (18:06 +0200)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 19 Mar 2024 15:46:23 +0000 (16:46 +0100)
Commit 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use
of_graph_get_remote_node()") simplified the thc63lvd1024 driver by
replacing hand-rolled code with a helper function. While doing so, it
created an error code path at probe time without any error message,
potentially causing probe issues that get annoying to debug. Fix it by
adding an error message.

Fixes: 00084f0c01bf ("drm: bridge: thc63lvd1024: Switch to use of_graph_get_remote_node()")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://lore.kernel.org/r/20240318160601.2813-1-laurent.pinchart+renesas@ideasonboard.com
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240318160601.2813-1-laurent.pinchart+renesas@ideasonboard.com
drivers/gpu/drm/bridge/thc63lvd1024.c

index 5f99f9724081e2a1fb234dbb86bf74fa6d4ac05c..674efc489e3a9fe6d41319b7dc4f9ed7ac0c79c7 100644 (file)
@@ -125,8 +125,11 @@ static int thc63_parse_dt(struct thc63_dev *thc63)
 
        remote = of_graph_get_remote_node(thc63->dev->of_node,
                                          THC63_RGB_OUT0, -1);
-       if (!remote)
+       if (!remote) {
+               dev_err(thc63->dev, "No remote endpoint for port@%u\n",
+                       THC63_RGB_OUT0);
                return -ENODEV;
+       }
 
        thc63->next = of_drm_find_bridge(remote);
        of_node_put(remote);