arm64: dts: qcom: msm8916: Declare sound node in msm8916.dtsi
authorStephan Gerhold <stephan@gerhold.net>
Mon, 20 Jul 2020 08:53:58 +0000 (10:53 +0200)
committerBjorn Andersson <bjorn.andersson@linaro.org>
Tue, 15 Sep 2020 04:48:08 +0000 (04:48 +0000)
The "sound" node in apq8016-sbc.dtsi references memory regions
provided by the SoC and should be therefore declared in msm8916.dtsi.

Additionally, the machine driver used for the "qcom,apq8016-sbc-sndcard"
compatible also works on other MSM8916 devices (provided that audio
routing is set up properly). It is not really specific to apq8016-sbc.

Simplify setting up sound on other boards by moving the common part
to msm8916.dtsi. This also allows referencing the node by the label,
so that we can eventually drop the "soc" node entirely from the
board-specific device tree part and use labels exclusively.

Cc: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Signed-off-by: Stephan Gerhold <stephan@gerhold.net>
Link: https://lore.kernel.org/r/20200720085406.6716-3-stephan@gerhold.net
Signed-off-by: Bjorn Andersson <bjorn.andersson@linaro.org>
arch/arm64/boot/dts/qcom/apq8016-sbc.dtsi
arch/arm64/boot/dts/qcom/msm8916.dtsi

index cb9c70a1532adf91d737280bb9f4862228646b8d..bfc5859726ae01aec0bc3a1c538be9dbd70ea829 100644 (file)
 
                */
 
-               sound: sound {
-                       compatible = "qcom,apq8016-sbc-sndcard";
-                       reg = <0x07702000 0x4>, <0x07702004 0x4>;
-                       reg-names = "mic-iomux", "spkr-iomux";
-
+               sound: sound@7702000 {
                        status = "okay";
                        pinctrl-0 = <&cdc_pdm_lines_act &ext_sec_tlmm_lines_act &ext_mclk_tlmm_lines_act>;
                        pinctrl-1 = <&cdc_pdm_lines_sus &ext_sec_tlmm_lines_sus &ext_mclk_tlmm_lines_sus>;
index 67cae5f9e47e68b401500b1be663ea2d99fb3186..8b12961f32690bfa78c7b69238fd3effc2e35ca1 100644 (file)
                        status = "disabled";
                };
 
+               sound: sound@7702000 {
+                       status = "disabled";
+                       compatible = "qcom,apq8016-sbc-sndcard";
+                       reg = <0x07702000 0x4>, <0x07702004 0x4>;
+                       reg-names = "mic-iomux", "spkr-iomux";
+               };
+
                lpass: lpass@7708000 {
                        status = "disabled";
                        compatible = "qcom,lpass-cpu-apq8016";