io_uring: fix blocking inline submission

There is a complaint against sys_io_uring_enter() blocking if it submits
stdin reads. The problem is in __io_file_supports_async(), which
sees that it's a cdev and allows it to be processed inline.

Punt char devices using generic rules of io_file_supports_async(),
including checking for presence of *_iter() versions of rw callbacks.
Apparently, it will affect most of cdevs with some exceptions like
null and zero devices.

Cc: stable@vger.kernel.org
Reported-by: Birk Hirdman <lonjil@gmail.com>
Signed-off-by: Pavel Begunkov <asml.silence@gmail.com>
Link: https://lore.kernel.org/r/d60270856b8a4560a639ef5f76e55eb563633599.1623236455.git.asml.silence@gmail.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/fs/io_uring.c b/fs/io_uring.c
index b93fa32172af9c5ecf6cb637e0464126e3da1b9c..cdd9b53abbb24f0b0a4a5c23bdd2bb951248c49a 100644 (file)
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -2618,7 +2618,7 @@ static bool __io_file_supports_async(struct file *file, int rw)
                        return true;
                return false;
        }
-       if (S_ISCHR(mode) || S_ISSOCK(mode))
+       if (S_ISSOCK(mode))
                return true;
        if (S_ISREG(mode)) {
                if (IS_ENABLED(CONFIG_BLOCK) &&